httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: svn commit: r958094 - /httpd/httpd/trunk/modules/aaa/mod_authn_socache.c
Date Wed, 30 Jun 2010 21:17:59 GMT
On 25 Jun 2010, at 9:27 PM, wrowe@apache.org wrote:

> C99 is not a requirement, fix style violation niq refuses(?) to  
> correct.

Out of genuine curiosity, can you explain why...

>     apr_status_t rv;
> +    const char *key;
>     unsigned char val[MAX_VAL_LEN];
>     unsigned int vallen = MAX_VAL_LEN - 1;

>     authn_cache_dircfg *dcfg = ap_get_module_config(r->per_dir_config,
>                                                      
> &authn_socache_module);

...the above line is not a style violation, but...

> -    const char *key = construct_key(r, dcfg->context, user, NULL);

...the above line is?

As I recall, rpluem asked for the same clarification.

/me would like to understand so he doesn't make the same mistake in  
future.

Regards,
Graham
--


Mime
View raw message