Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 17952 invoked from network); 4 May 2010 20:04:39 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 4 May 2010 20:04:39 -0000 Received: (qmail 85958 invoked by uid 500); 4 May 2010 20:04:38 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 85913 invoked by uid 500); 4 May 2010 20:04:38 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 85905 invoked by uid 99); 4 May 2010 20:04:38 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 May 2010 20:04:38 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates 209.85.160.45 as permitted sender) Received: from [209.85.160.45] (HELO mail-pw0-f45.google.com) (209.85.160.45) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 May 2010 20:04:31 +0000 Received: by pwi6 with SMTP id 6so1773826pwi.18 for ; Tue, 04 May 2010 13:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=Bm/KOPqB40tM3im0Qyz/dmFjLQhBQH4E7/mC3V+IK/I=; b=EElN2lEvcoMf2B4ySQ8qidvO8BOJN1wGmys3f8JLqtQDCKqP22ucKhtcqTM8I1y6oe ScZzJui0uZQESuNe+zQ0u5KWvcstyUDOA9wi/X13mz6fSfkd34nM/+8Wd1qaQkLEuOX/ N8r5ur3qxIdbUUSDwdLdjTsSiYnGo9D0sF/30= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=hExzEdLrf/I3RFdMfIz66RXF0crkrxnaldXlI7ru4956Dd4pLLgURWJWZgkUYsZbb7 QIuTg8n6AFLV/iKBmniadCHTAopwxqCOHXXYMgup21nLjblvLsK+jKwz30cmOZdTJxIQ 3U4bqRKGGBCnaZpC1sSMWJQeuu9tcmVPSZSIg= MIME-Version: 1.0 Received: by 10.142.195.20 with SMTP id s20mr722712wff.248.1273003450230; Tue, 04 May 2010 13:04:10 -0700 (PDT) Received: by 10.143.35.7 with HTTP; Tue, 4 May 2010 13:04:10 -0700 (PDT) In-Reply-To: References: <4BE0728A.3010602@rowe-clan.net> Date: Tue, 4 May 2010 16:04:10 -0400 Message-ID: Subject: Re: Solving util_mutex pain? From: Jeff Trawick To: dev@httpd.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Tue, May 4, 2010 at 4:00 PM, Jeff Trawick wrote: > On Tue, May 4, 2010 at 3:16 PM, William A. Rowe Jr. = wrote: >> Here's a backport vote to 2.2 for your consideration; >> >> It is far too painful to adopt the new Mutex directive for modules targe= ting >> httpd 2.2 and future 2.3. > > From your example URL below, it looks like a developer can maintain > only about 15-20 extra LOC in order to utilize the new Mutex feature > of 2.4 and at the same time continue working exactly the same for the > other httpd versions. > > Wouldn't they rather do that than deal with migration as users move to > a later httpd 2.2 and then, perhaps much later, rebuild the > third-party module? =A0("do you have a LoadModule for mod_mutex?"; > "FooLogMutex isn't supported once you rebuild with httpd 2.2.19"; > "please download mod_mutex from svn and build with apxs", depending on > the choice of the module author) > >> =A0The solution, I believe, is to provide the mutex >> directive for all developers to use, and simply not adopt it within http= d itself >> until our jump to 2.4 happens. If mod_mutex gets added to 2.2, I'd suggest a nuance to this "not adopt" st= ance: If the httpd-bundled module currently has no mutex configuration and it is necessary to solve some operational problem, go ahead and use the mod_mutex feature. But for mod_ssl and others that already provide configuration, leave it as-is. >> >> To that end, I've hacked together >> =A0http://people.apache.org/wrowe/mod_mutex.c >> =A0http://people.apache.org/wrowe/util_mutex.h >> which I'm propose we adopt for inclusion in both our httpd 2.2 and 2.0 t= rees under >> 'experimental/', and default to build 'most' (effectively, an ever prese= nt no-op, >> until they add an external module that relies on it). > > trivial: I don't think "experimental" and "most" are consistent. > >> If this is accepted, it would become a prereq for users adopting new rel= eases >> of mod_fcgid or mod_ftp. > > separate issue/vote (maintain those extra LOC in mod_fcgid until it is > folded into trunk for 2.4* vs. require migration step for users of > older httpd) > > *yet another issue :) > >> =A0 =A0You can review the source code to see how badly we >> need a simpler solution; >> http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_m= utex_unix.c?view=3Dmarkup&pathrev=3D885868 >> - of course the user of a slightly >> older 2.2.x or 2.0.x could simply build mod_mutex with apxs and then the= ir module, >> and they also must install util_mutex.h for dependent module builds to s= ucceed. >> >> So please review and opine... >> >> =A0+/-1 > > [+0.5 concept] =A0Adopt mod_mutex.c on httpd 2.2.x svn branch > > I haven't looked at mod_mutex, but no big concerns here; the API is > useful; I'd guess some module authors would be relieved to use that > feature if their users currently have mutex issues that require > configuration, and the module doesn't already provide that > > [-0.8] =A0Adopt mod_mutex.c on httpd 2.0.x svn branch > > - too late for new features unless absolutely critical to solve some > operational problem > - not abundantly clear that there will ever be 2.0.next, so developers > shouldn't think that mod_mutex solves their issue for support of that > server, unless of course the developer wants to hand-hold the download > and build of mod_mutex > > -- Hmmm, at least one e-mail client thinks the remaining text is a sig because of my poor choice of separator. > Wild guess: maybe mod_mutex for 2.0/2.2 just needs a home somewhere in > httpd-land, outside of the main server distribution? =A0I have a couple > I'd put in the same LIFEboat. > --=20 Born in Roswell... married an alien...