Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 56544 invoked from network); 15 Feb 2010 00:47:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Feb 2010 00:47:39 -0000 Received: (qmail 52729 invoked by uid 500); 15 Feb 2010 00:47:38 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 52647 invoked by uid 500); 15 Feb 2010 00:47:38 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 52638 invoked by uid 99); 15 Feb 2010 00:47:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Feb 2010 00:47:38 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of minfrin@sharp.fm designates 72.32.122.20 as permitted sender) Received: from [72.32.122.20] (HELO chandler.sharp.fm) (72.32.122.20) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Feb 2010 00:47:30 +0000 Received: from chandler.sharp.fm (localhost [127.0.0.1]) by chandler.sharp.fm (Postfix) with ESMTP id 5C34D780D4 for ; Sun, 14 Feb 2010 18:47:09 -0600 (CST) Received: from 87-194-125-16.bethere.co.uk (87-194-125-16.bethere.co.uk [87.194.125.16]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) (Authenticated sender: minfrin@sharp.fm) by chandler.sharp.fm (Postfix) with ESMTP id AC9C3780D3 for ; Sun, 14 Feb 2010 18:47:08 -0600 (CST) Message-Id: From: Graham Leggett To: dev@httpd.apache.org In-Reply-To: <4B782AEE.70900@apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: svn commit: r910017 - in /httpd/httpd/trunk: CHANGES docs/manual/filter.xml docs/manual/mod/allmodules.xml docs/manual/mod/mod_reflector.xml modules/filters/config.m4 modules/filters/mod_reflector.c Date: Mon, 15 Feb 2010 02:47:05 +0200 References: <20100214151000.C403823888E2@eris.apache.org> <4B782AEE.70900@apache.org> X-Mailer: Apple Mail (2.936) X-Virus-Scanned: ClamAV using ClamSMTP On 14 Feb 2010, at 6:55 PM, Ruediger Pluem wrote: > + /* >> >> + * We MUST read because in case we have an unknown- >> length >> + * bucket or one that morphs, we want to exhaust it. >> + */ >> + status = apr_bucket_read(bucket, &data, &len, >> APR_BLOCK_READ); > > Can't we check first if this bucket is of unknown length and only > read if it is? > Otherwise we could move it just over to the output brigade, correct? I tried that and it didn't work for me. Without the apr_bucket_read(), no EOS bucket is ever generated, and the loop spins. Regards, Graham --