Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 17955 invoked from network); 5 Feb 2010 17:40:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 5 Feb 2010 17:40:37 -0000 Received: (qmail 80927 invoked by uid 500); 5 Feb 2010 17:40:36 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 80853 invoked by uid 500); 5 Feb 2010 17:40:35 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 80844 invoked by uid 99); 5 Feb 2010 17:40:35 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2010 17:40:35 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [188.40.99.202] (HELO eru.sfritsch.de) (188.40.99.202) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Feb 2010 17:40:28 +0000 Received: from [10.1.1.6] (helo=k.localnet) by eru.sfritsch.de with esmtp (Exim 4.69) (envelope-from ) id 1NdSA3-0007b9-Ox for dev@httpd.apache.org; Fri, 05 Feb 2010 18:40:07 +0100 From: Stefan Fritsch To: dev@httpd.apache.org Subject: Re: svn commit: r905454 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_config.h modules/debugging/mod_dumpio.c server/core.c server/log.c server/main.c Date: Fri, 5 Feb 2010 18:40:07 +0100 User-Agent: KMail/1.12.4 (Linux/2.6.32-trunk-amd64; KDE/4.3.4; x86_64; ; ) References: <20100201232733.51479238897F@eris.apache.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201002051840.07588.sf@sfritsch.de> X-Virus-Checked: Checked by ClamAV on apache.org On Thursday 04 February 2010, Jim Jagielski wrote: > > + char *err = "Loglevel keyword must be one of > > emerg/alert/crit/error/warn/" > > + "notice/info/debug"; > > + int i = 0; > > Won't this be confusing that every error would refer to Loglevel, > even if the bad directive is "DumpIOLogLevel" for example? Why not > also pass the directive name as well? True. I have clarified the error message in r907012. But I hope that DumpIOLogLevel will go away before 2.4 ;-)