httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] mod_fcgid: SEGV with empty output from fcgi process
Date Mon, 01 Feb 2010 12:08:55 GMT
On Mon, Feb 1, 2010 at 2:25 AM, Tatsuki Sugiura <sugi@nemui.org> wrote:
> Hello,
>
>>>> In Message "Re: [PATCH] mod_fcgid: SEGV with empty output from fcgi process"
>>>>            <cc67648e1001310433y67082e56nd76327314ad21bda@mail.gmail.com>,
>>>> Jeff Trawick <trawick@gmail.com>  said;
>> > a) is it better (and practical) to ensure that the brigade has an EOS
>> > bucket to start with so this special case doesn't have to be handled
>
>> I was tricked by the existing check for EOS; there never is one AFAICT
>> (the "done" flag is the usual escape from the loop).  So your new
>> check stays and the EOS check goes.
>
>> > b) how to get a 500 error to the client in this situation (the FastCGI
>> > app returns no headers)
>
>> I still need to look at this (cgid returns 500 in this case)
>
> Thanks for your work!
>
> I confirmed r905031 in my environment.
> It seems you fixed both already, correct?

Yes; thanks again!

Mime
View raw message