httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fred Moyer <f...@redhotpenguin.com>
Subject Re: [RELEASE CANDIDATE] Apache-Test-1.31 RC2
Date Sat, 13 Feb 2010 04:51:25 GMT
On Tue, Feb 9, 2010 at 6:40 PM, Philippe M. Chiasson
<gozer@ectoplasm.org> wrote:
>
> One small nit, not sure why, but t/next_available_port.t was modified
> and will only be run if mod_cgi *and* mod_cgid is installed, which is
> not very likely. Shouldn't this be what it does instead ?
>
> diff -rdu Apache-Test-1.31-rc2/t/next_available_port.t
> Apache-Test-1.31-rc2.test/t/next_available_port.t
> --- Apache-Test-1.31-rc2/t/next_available_port.t        2009-04-18
> 05:59:26.000000000 -0400
> +++ Apache-Test-1.31-rc2.test/t/next_available_port.t   2010-02-09
> 21:20:26.000000000 -0500
> @@ -7,8 +7,7 @@
>  use Apache::TestRequest;
>  use Apache::TestUtil;
>
> -plan tests => 1, need need_module('mod_cgi.c'),
> -                 need_module('mod_cgid.c'),
> +plan tests => 1, need need_cgi,
>                  need_module('mod_env.c');

Yes, thanks for the spot there.  Applied.


> Looking at Changes, I can see
>
> "Use need_module('mod_cgi.c') and need_module('mod_cgid.c') in
> t/next_available_port.t instead of need_cgi.  On case insensitive file
> systems such as OS X, need_cgi will fulfill the requirement with cgi.pm,
> when mod_cgi.c is the desired requirement.
> [Fred Moyer <phred@apache.org>]"
>
> Wouldn't the correct solution be to fix need_cgi then :
>
> diff -ru Apache-Test-1.31-rc2.test/blib/lib/Apache/Test.pm
> Apache-Test-1.31-rc2/blib/lib/Apache/Test.pm
> --- Apache-Test-1.31-rc2.test/blib/lib/Apache/Test.pm   2010-02-09
> 13:21:39.000000000 -0500
> +++ Apache-Test-1.31-rc2/blib/lib/Apache/Test.pm        2010-02-09
> 21:27:47.000000000 -0500
> @@ -348,7 +348,7 @@
>  }
>
>  sub need_cgi {
> -    return _need_multi(qw(cgi cgid));
> +    return _need_multi(qw(cgi.c cgid.c));
>  }

Ah, this is a much better approach.  I don't think I completely
understood that _need_multi was OR instead of AND last time I looked
at it.

Both changes applied r909744.  Thanks Philippe!

Mime
View raw message