httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: [PATCH] mod_proxy sessions
Date Mon, 01 Feb 2010 18:39:48 GMT
On 01 Feb 2010, at 7:48 PM, yle wrote:

> Yes, it would be a better to use a module of its own, I have to  
> better look at the proxy hooks to see how the proxy_session module  
> could do the job elsewhere (most of the code would be that of the  
> http module I guess, but I need to look closer).
> My first goal was to make it work ...

Makes sense, you have to start somewhere.

> I wanted ap_proxy_acquire_connection() be able to access the r- 
> >notes and r->connection (for the session-id/client to be  
> dynamically set-able), the server record was of no help for me.

I recall running into a similar dilemma a while back, I think the  
change from server_rec to request_rec does make sense.

Such a change would only be possible on trunk though, as the ABI for  
2.2 is cast in stone at this point. Trunk has started being released  
as an alpha version, so a potential server_rec to request_rec change  
should see the light of day quite soon.

I suggest breaking the patch down into at the least:

- The APR changes, to be submitted to the APR project as a unit.

- The server_rec -> request_rec change, which can go in on its own.

- The rest can follow.

Regards,
Graham
--


Mime
View raw message