httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r905454 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_config.h modules/debugging/mod_dumpio.c server/core.c server/log.c server/main.c
Date Thu, 04 Feb 2010 13:43:06 GMT

On Feb 1, 2010, at 6:27 PM, sf@apache.org wrote:
> -        else {
> -            return "DumpIOLogLevel requires level keyword: one of "
> -                   "emerg/alert/crit/error/warn/notice/info/debug";
> -        }
> +        err = ap_parse_log_level(str, &ptr->loglevel);
> +        if (err != NULL)
> +            return err;
>     }
...
> -        else {
> -            return "LogLevel requires level keyword: one of "
> -                   "emerg/alert/crit/error/warn/notice/info/debug";
> -        }
> +        err = ap_parse_log_level(arg, &cmd->server->loglevel);
> +        if (err != NULL)
> +            return err;
>     }
>     else {
>         return "LogLevel requires level keyword";
...

> +    char *err = "Loglevel keyword must be one of emerg/alert/crit/error/warn/"
> +                "notice/info/debug";
> +    int i = 0;

Won't this be confusing that every error would refer to Loglevel, even if the
bad directive is "DumpIOLogLevel" for example? Why not also pass the directive
name as well?
Mime
View raw message