httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Plüm, Rüdiger, VF-Group" <ruediger.pl...@vodafone.com>
Subject RE: mod_proxy_http ignores errors from ap_pass_brigade(r->output_filters)
Date Thu, 11 Feb 2010 07:34:44 GMT
 

> -----Original Message-----
> From: Aaron Bannert 
> Sent: Donnerstag, 11. Februar 2010 00:04
> To: dev@httpd.apache.org
> Subject: mod_proxy_http ignores errors from 
> ap_pass_brigade(r->output_filters)
> 
> mod_proxy_http appears to be ignoring errors returned from 
> ap_pass_brigade
> (when passing down the output_filter stack). This is a problem for any
> output filter that has a fatal error and wishes to signal that error
> to the client (eg. HTTP_INTERNAL_SERVER_ERROR). I'm not 
> familiar enough
> with the current mod_proxy code to know if I did this correctly, but
> this patch works for me. I also went ahead and marked the places where
> we (kind of hackishly) ignore the return values intentionally.
> 
> Could someone review this and let me know if I'm on the right track
> (against 2.2.x branch)?

IMHO this is unneeded and indicates a bug in the according filter.
Filters return apr error codes and not HTTP status codes. If they wish
to set a specific status code they should pass an error bucket down the
chain or set r->status appropriately.

Regards

Rüdiger



Mime
View raw message