httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: mod_proxy_http ignores errors from ap_pass_brigade(r->output_filters)
Date Fri, 12 Feb 2010 08:23:59 GMT

On 11 Feb 2010, at 19:47, Aaron Bannert wrote:

>> IMHO this is unneeded and indicates a bug in the according filter.
>> Filters return apr error codes and not HTTP status codes. If they wish
>> to set a specific status code they should pass an error bucket down the
>> chain or set r->status appropriately.
> 
> You are correct that filters should be returning apr status codes and
> not http status codes, thanks for pointing that out. I'm still a little
> concerned about how this is supposed to work though, since it seems like
> the mod_proxy_http handler behaves differently than the default handler.

There's quite a lot of history to this.  We fixed bugs in specific handers,
only to find the same in other handlers.  So we put a workaround in core.
It would probably be a good idea to look at that if you're revisiting this
area of the code.

See https://issues.apache.org/bugzilla/show_bug.cgi?id=31759,
especially the last dozen or so comments and their references.
(I'm sure there's more; that's just something I dug up).

-- 
Nick Kew

Mime
View raw message