httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r907917 - in /httpd/httpd/trunk: include/ap_mmn.h include/ap_socache.h modules/cache/mod_socache_dbm.c modules/cache/mod_socache_dc.c modules/cache/mod_socache_memcache.c modules/cache/mod_socache_shmcb.c
Date Wed, 10 Feb 2010 08:51:25 GMT
On Tue, Feb 09, 2010 at 03:43:18AM -0000, William Rowe wrote:
> Author: wrowe
> Date: Tue Feb  9 03:43:18 2010
> New Revision: 907917
> 
> URL: http://svn.apache.org/viewvc?rev=907917&view=rev
> Log:
> distcache already demonstrates sub-second resolutions, but much more
> importantly, let us not introduce more Y2k38 bugs?
> 
> Changes the ->store method to take expiry as an apr_time_t, and introduce
> a placeholder to implement provider-specific iterators of the current
> elements of an socache store.
> 
> Cleans up confusion where expiry might be confused with a timeout-period.

Thanks Bill!

> Finally clean up some hUngarian noteAtion.  Someones' hands need to be slapped.

It's all Ben's fault, he started it :)

One minor comment:

> @@ -156,12 +180,28 @@
>  
>      /** Dump the status of a cache instance for mod_status.  Will use
>       * the ap_r* interfaces to produce appropriate status output.
> +     * XXX: apr_r* are deprecated, bad dogfood

$ grep -i deprecated http_protocol.h 
$

No they aren't ;) ... and I don't think they should be either, they are 
fine interfaces which have worked forever.

joe

Mime
View raw message