httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: [PATCH] LogLevel refactoring part 1
Date Wed, 03 Feb 2010 19:13:21 GMT
On Wednesday 03 February 2010, Eric Covener wrote:
> On Wed, Feb 3, 2010 at 3:22 AM, Stefan Fritsch <sf@sfritsch.de> 
wrote:
> > loglevel_trace.diff:
> > Introduce additional log levels trace1 ... trace8 above the debug
> > level.
> 
> I recall that having so many was to accomodate RewriteLogLevel, but
> IMO the 9 settings there really boil down to about 3 or 4 in
>  practical terms IMO.

8 trace log levels is the natural number that comes from extending 
APLOG_LEVELMASK by one bit. I agree that most modules won't need more 
than 3 or 4.

I don't see any advantage in supporting fewer than 8 trace levels, but 
there could of course be some agreement that modules included with 
httpd use only a subset.

mod_rewrite uses 6 of its theoretically 9 RewriteLogLevel values. I 
don't know if some of these 6 are of little practical value, and 
personally I would like to avoid the work of having to combine some of 
them.

Therefore I would just use trace1 to trace6 for mod_rewrite. One could 
set APLOG_MAX_LOGLEVEL to trace6 by default. Then log messages of 
level trace7/8 would be removed during compilation on C99 compilers.

Mime
View raw message