Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of apache-dev@m.gmane.org
 designates 80.91.229.12 as permitted sender)
To: dev@httpd.apache.org
From: Dan Poirier <poirier@pobox.com>
Subject: Re: mod_reqtimeout backport
Date: Wed, 13 Jan 2010 09:27:51 -0500
Lines: 42
Message-ID: <yuamy0i3wrc.fsf@pobox.com>
References: <20100109195247.B53EC238899B@eris.apache.org>
	<yuapr5fgnkp.fsf@slappy.raleigh.ibm.com>
	<201001130030.37405.sf@sfritsch.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (darwin)
Cancel-Lock: sha1:kCSDFc4qfni3wFScazU93qRJxCU=
Sender: news <news@ger.gmane.org>

Stefan Fritsch <sf@sfritsch.de> writes:

> I am not particularly happy about the syntax, yet. I just had the idea 
> to have one keyword xxx that can optionally accept a range, instead of 
> two keywords xxxinit and xxxmax:
>
> 	Header=30
> 	Body=5-50 BodyMinRate=500
>
> or 
>
>     Header=5-20,minrate=500
>     Body=5-50,minrate=500
>
> but the combination
>
>     Header=5,minrate=1000
>
> is less clear. Maybe make the '-' mandatory in this case:
>
>     Header=5-,minrate=1000
>
> Any opinions or better ideas?
>
> One could also rename RequestTimeout into RequestReadTimeout if that 
> makes it easier to understand.

We might simplify the model by not exposing the internal extending of
the timeout.  Just let the admin specify an overall max time, a minimum
rate, or both:

  HeaderTimeout: Maximum seconds to read the entire header.

  HeaderMinRate: Minimum rate (bytes/second) allowed when reading the
  request header.  If the rate drops below this, the request is timed
  out.

We'd enforce both if specified.  In that case HeaderTimeout would act
like headermax.  Internally we'd probably implement HeaderMinRate by
gradually extending a timeout, but we wouldn't be tied to that.

Dan