httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] mod_fcgid: SEGV with empty output from fcgi process
Date Sat, 30 Jan 2010 12:41:09 GMT
On Fri, Jan 29, 2010 at 3:25 AM, Tatsuki Sugiura <sugi@nemui.org> wrote:
> Hello all,
>
> I found a problem that mod_fcgi makes segmentation fault
> when FastCGI process returns empty outout. It's caused
> with missing to check end of brigade when parsing CGI
> response header.
>
> I worte a patch to fix this, and attach on this mail.
> Please review.

Thanks for the patch.  I've reproduced the error and confirmed that
your patch solves the segfault.  I hope to look at a couple of other
aspects:

a) is it better (and practical) to ensure that the brigade has an EOS
bucket to start with so this special case doesn't have to be handled
b) how to get a 500 error to the client in this situation (the FastCGI
app returns no headers)

Mime
View raw message