Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
From: Stefan Fritsch <sf@sfritsch.de>
To: dev@httpd.apache.org
Subject: Re: svn commit: r834049 - in /httpd/httpd/trunk: CHANGES
 modules/dav/fs/lock.c modules/dav/fs/repos.c
Date: Mon, 9 Nov 2009 20:46:53 +0100
User-Agent: KMail/1.12.2 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; )
References: <20091109131408.4FE5323888CE@eris.apache.org>
 <200911091442.21581.sf@sfritsch.de>
 <6cca3db30911090652q5f7f13c5x9b4364c7e9ff3f5c@mail.gmail.com>
In-Reply-To: <6cca3db30911090652q5f7f13c5x9b4364c7e9ff3f5c@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200911092046.53615.sf@sfritsch.de>

On Monday 09 November 2009, Greg Stein wrote:
> >> Why did you go with a format change of the DAVLockDB? It is
> >> quite possible that people will miss that step during an
> >> upgrade. You could just leave DAV_TYPE_FNAME in there.
> >
> > That wouldn't help because it would still break with
> > DAV_TYPE_INODE locks existing in the DAVLockDB. Or am I missing
> > something?
> 
> Heh. Yeah. I realized that right after I hit the Send button :-P
> 
> Tho: mod_dav could error if it sees an unrecognized type, rather
>  than simply misinterpreting the data and silently unlocking all
>  nodes.

What do you want to do exactly? Check the db at httpd startup and 
abort if it contains old format entries? I don't think it is possible 
to convert the entries, at least not without traversing the whole dav 
tree.

In any case, I wonder if this is worth the effort. It definitely isn't 
for 2.2 -> 2.4 upgrades. And if we backport the changes to 2.2.x, I 
would still primarily see it as responsibility of the distributors to 
warn the user/remove the old db in postinst/etc.

And for those people who compile it themselves and run a system 
critical enough that they cannot affort to loose the locks during an 
httpd upgrade, those people should really read the changelog.

Cheers,
Stefan