httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r883816 - in /httpd/httpd/trunk: include/util_mutex.h server/util_mutex.c
Date Tue, 24 Nov 2009 20:11:20 GMT
On Tue, Nov 24, 2009 at 2:50 PM, William A. Rowe Jr.
<wrowe@rowe-clan.net> wrote:
> trawick@apache.org wrote:
>> --- httpd/httpd/trunk/include/util_mutex.h (original)
>> +++ httpd/httpd/trunk/include/util_mutex.h Tue Nov 24 19:06:16 2009
>> @@ -99,9 +99,9 @@
>>                                          const char **mutexfile);
>>
>>  /* private function to process the Mutex directive */
>> -AP_DECLARE(const char *) ap_set_mutex(cmd_parms *cmd, void *dummy,
>> -                                      const char *typelist,
>> -                                      const char *mechfile);
>
> If this is a public function (and it is named as one) please revert ;-)

I used ap_set_name_virtual_host() as an example due to its unfortunate
locality to "Mutex" in the list of directives in server/core.c.  It is
also an undecorated "const char *ap_set_name_virtual_host()".

Many if not all other functions which handle directives and which are
not implemented in the same file as the directive declaration also
have the ap_ prefix, so I don't follow you on the "public" aspect.

But most of these other functions are declared with
AP_DECLARE_NONSTD().  That seems to be appropriate for ap_set_mutex(),
ap_set_name_virtual_host(), and perhaps others.

Is that the fix?

Mime
View raw message