httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r883540 - in /httpd/httpd/trunk: ./ build/ docs/conf/ docs/conf/extra/ include/ modules/aaa/ modules/core/ modules/examples/ modules/generators/ modules/ldap/ modules/mappers/ modules/ssl/ server/ server/mpm/prefork/ server/mpm/worker
Date Tue, 24 Nov 2009 11:52:18 GMT
On Mon, Nov 23, 2009 at 6:59 PM, Jeff Trawick <trawick@gmail.com> wrote:
> On Mon, Nov 23, 2009 at 6:33 PM, William A. Rowe Jr.
> <wrowe@rowe-clan.net> wrote:
>> trawick@apache.org wrote:
>>> Author: trawick
>>> Date: Mon Nov 23 23:17:51 2009
>>> New Revision: 883540
>>>
>>> URL: http://svn.apache.org/viewvc?rev=883540&view=rev
>>> Log:
>>> Replace AcceptMutex, LockFile, RewriteLock, SSLMutex, SSLStaplingMutex,
>>> and WatchdogMutexPath with a single Mutex directive.  Add APIs to
>>> simplify setup and user customization of APR proc and global mutexes.
>>> (See util_mutex.h.)  Build-time setting DEFAULT_LOCKFILE is no longer
>>> respected; set DEFAULT_REL_RUNTIMEDIR instead.
>>
>> I haven't spent enough time follow the discussion thread, but there is a
>> pretty big concern here.
>>
>> Let's say we pick NFS for our SSL session store, which means we need an fcntl
>> or file lock to mutex the session cache.  But if these others were all machine
>> local (and hopefully, easily threadproc mutexible, such as a pthread mutex or
>> at worst case, a sysv sem) then the optimal no longer mirrors the appropriate
>> match based on the resource.
>>
>> Can we perhaps partially revert to allow these to be -overrides- of the system
>> wide mutex mechanism, e.g. sysv sem might be right for all but two resources.
>> Let those two be overridden (and point out, in the docs, when this would become
>> necessary).

> What is missing for your scenario AFAICT is having a predictable lock
> file name so that different nodes can share the same mutex file.
> Currently on Unix the pid will always be appended to the lock file
> name.

Interestingly, the mod_ssl doc currently states that the pid will be
appended automatically to the file specified in SSLMutex.  You removed
the corresponding code in 2003 with the comment "It also removes the
mod_ssl historical '.pid' suffixes - that isn't how Apache2 specifies
files."

Mime
View raw message