httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r880981 - /httpd/httpd/trunk/build/instdso.sh
Date Mon, 16 Nov 2009 22:07:55 GMT
On Mon, Nov 16, 2009 at 4:51 PM,  <trawick@apache.org> wrote:
> Author: trawick
> Date: Mon Nov 16 21:51:01 2009
> New Revision: 880981
>
> URL: http://svn.apache.org/viewvc?rev=880981&view=rev
> Log:
> tweak r823613/PR 47951 change to avoid /usr/sbin/install on
> Solaris
>
> (not compatible with BSD install)
>
> Modified:
>    httpd/httpd/trunk/build/instdso.sh
>
> Modified: httpd/httpd/trunk/build/instdso.sh
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/build/instdso.sh?rev=880981&r1=880980&r2=880981&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/build/instdso.sh (original)
> +++ httpd/httpd/trunk/build/instdso.sh Mon Nov 16 21:51:01 2009
> @@ -49,7 +49,15 @@
>     $CMD || exit $?
>  fi
>
> -type install >/dev/null 2>&1 && INSTALL_CMD=install || INSTALL_CMD=cp
> +case $SYS in
> +    SunOS)
> +        INSTALL_CMD=cp
> +        ;;
> +    *)
> +        type install >/dev/null 2>&1 && INSTALL_CMD=install ||
INSTALL_CMD=cp

Perhaps this is just a temporary change, but from the
/usr/sbin/install permission denied messages I saw I'd hate for anyone
to run "make install" or apxs with superuser privileges.

The original complaint in the PR was that using cp to install DSOs
over a running server caused the server to segfault.  If indeed
replacing shared libraries underneath a running server is something we
want to acknowledge, we could rm it in instdso.sh before running
libtool ... cp foo.la libexecdir.  We already do that on AIX for other
reasons.

Alternatively, we could get the results of AC_PROG_INSTALL into instdso.sh.

Mime
View raw message