httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@gmail.com>
Subject Re: dav_new_error_*() and errno, revisit before 2.4 GA
Date Wed, 11 Nov 2009 23:58:08 GMT
On Wed, Nov 11, 2009 at 17:11, Jeff Trawick <trawick@gmail.com> wrote:
> At present, whatever was in errno at the time the dav_error {} was
> created is treated as an apr_status_t by ap_log_rerror().
>
> http://mail-archives.apache.org/mod_mbox/httpd-dev/200211.mbox/%3C20021101033848.B29006@lyra.org%3E
>
> dav_error {} should have an apr_status_t field instead of an errno
> field; functions which create a dav_error should have an apr_status_t
> parameter.
>
> If there's no direct apr_status_t representation of the error, the
> caller will have to decide what to do (no magic portable solution
> AFAIK, but no worse than today).
>
> Concerns?

dav_error was designed during the 1.3 series. APR wasn't even being
discussed. So yeah... there is definitely a disconnect from "then" to
"now".

I'd be quite supportive of changing that, though (strictly speaking)
that is probably an API change.

Cheers,
-g

Mime
View raw message