httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nick Kew <n...@webthing.com>
Subject Re: svn commit: r883816 - in /httpd/httpd/trunk: include/util_mutex.h server/util_mutex.c
Date Tue, 24 Nov 2009 20:17:51 GMT
William A. Rowe Jr. wrote:
> trawick@apache.org wrote:
>> --- httpd/httpd/trunk/include/util_mutex.h (original)
>> +++ httpd/httpd/trunk/include/util_mutex.h Tue Nov 24 19:06:16 2009
>> @@ -99,9 +99,9 @@
>>                                          const char **mutexfile);
>>  
>>  /* private function to process the Mutex directive */
>> -AP_DECLARE(const char *) ap_set_mutex(cmd_parms *cmd, void *dummy,
>> -                                      const char *typelist,
>> -                                      const char *mechfile);
> 
> If this is a public function (and it is named as one) please revert ;-)

Um, it appears to have been introduced in r883540 only yesterday,
and this was a revert (to private).

Regarding r883540 itself, I've just taken a look at it.
It seems to enforce the same mutex type on all modules that
use a mutex.  Can't see an obvious reason not to do that, but
it might merit discussion on-list.  For example, maybe someone
has a good reason to use different mutex types for a proc
mutex and a global mutex?

-- 
Nick Kew

Mime
View raw message