httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r882528 - /httpd/httpd/branches/2.0.x/STATUS
Date Fri, 20 Nov 2009 15:46:55 GMT
On 20.11.2009 13:09, rpluem@apache.org wrote:
> Author: rpluem
> Date: Fri Nov 20 12:09:17 2009
> New Revision: 882528
> 
> URL: http://svn.apache.org/viewvc?rev=882528&view=rev
> Log:
> * Comment and vote.
> 
> Modified:
>     httpd/httpd/branches/2.0.x/STATUS
> 
> Modified: httpd/httpd/branches/2.0.x/STATUS
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.0.x/STATUS?rev=882528&r1=882527&r2=882528&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.0.x/STATUS (original)
> +++ httpd/httpd/branches/2.0.x/STATUS Fri Nov 20 12:09:17 2009
> @@ -168,7 +168,15 @@
>      Backport version for 2.0.x of patch:
>        http://people.apache.org/~rjung/patches/cve-2009-3555_httpd_2_0_x.patch
>      +1: rjung
> +    rpluem says: Two comments
> +    1. IMHO backports are done from trunk not from other stable branches
> +    2. The patch causes the compiler warning below that was fixed in r881222
> +       on trunk. The backport should reflect this.
>  
> +ssl_engine_kernel.c: In function `ssl_callback_Info':
> +ssl_engine_kernel.c:1802: warning: passing arg 1 of `SSL_state' discards qualifiers
from pointer target type
> +
> +    Otherwise +1.
>  
>  PATCHES TO BACKPORT THAT ARE ON HOLD OR NOT GOING ANYWHERE SOON:

Thanks RĂ¼diger, I added the cast to the patch now.

How do you trigger the compiler warning? I saw the original commit, but
compiling with gcc 3.1.2 and -Wall against OpenSSL 0.9.8k didn't reveal
this warning.

Regards,

Rainer

Mime
View raw message