Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates
 72.14.220.155 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=aR2nrdZOOdFOP3/JEegXptvu5l7tPr0sCTg0TrG8oljHqCK7yFnU/WDu9K/i1Lku5y
         CTW8bre/RQ4oxOujy/ctwpyjnmtP8ToGW0A2K8JtYevoKWyndlPzZauzjDVA9YXWuDJK
         Jwq0CfIhYyjUmYVauDyYhKlFcd5O2eJw6X+QY=
MIME-Version: 1.0
In-Reply-To: <4ACF7239.3070307@onelan.co.uk>
References: <4ACF5F0A.7050706@onelan.co.uk>
	 <cc67648e0910090952r41a0aea4ufebfee6daf01d42b@mail.gmail.com>
	 <4ACF7239.3070307@onelan.co.uk>
Date: Fri, 9 Oct 2009 15:30:23 -0400
Message-ID: <cc67648e0910091230m6e552144ofddcefd459a69890@mail.gmail.com>
Subject: Re: mod_fcgid POST broken if FcgiAuthorizer is run
From: Jeff Trawick <trawick@gmail.com>
To: dev@httpd.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 9, 2009 at 1:26 PM, Barry Scott <barry.scott@onelan.co.uk> wrot=
e:
> Jeff Trawick wrote:
>>
>> On Fri, Oct 9, 2009 at 12:04 PM, Barry Scott <barry.scott@onelan.co.uk>
>> wrote:
>>
>>>
>>> This has been filed as issue
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=3D47973
>>>
>> See patch attached to the PR. =A0Thanks!
>>
>>
>
> No joy I get internal server error.
>
> But the patch below works for my case.
...

> Index: modules/fcgid/fcgid_bridge.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- modules/fcgid/fcgid_bridge.c =A0 =A0(revision 823573)
> +++ modules/fcgid/fcgid_bridge.c =A0 =A0(working copy)
> @@ -470,6 +470,8 @@
> =A0 =A0 =A0 =A0return HTTP_INTERNAL_SERVER_ERROR;
> =A0 =A0}
>
> + =A0 =A0if (role =3D=3D FCGI_RESPONDER) {
> +
> =A0 =A0/* Stdin header and body */
> =A0 =A0/* XXX HACK: I have to read all the request into memory before sen=
ding it
> =A0 =A0 =A0 to fastcgi application server, this prevents slow clients fro=
m
> @@ -624,6 +626,7 @@
> =A0 =A0 =A0 =A0apr_brigade_destroy(input_brigade);
> =A0 =A0}
> =A0 =A0while (!seen_eos);
> + =A0 =A0} /* end handling request body for responders */
>
> =A0 =A0/* Append an empty body stdin header */
> =A0 =A0stdin_request_header =3D apr_bucket_alloc(sizeof(FCGI_Header),
>
>

Variation number three:

As with your patch, it remembers to add the eos bucket to the brigade
of data sent to the app.  As with my earlier patch, it doesn't send
the trailing FCGI_STDIN record.

In the spec (http://www.fastcgi.com/devkit/doc/fcgi-spec.html#S6.3),
there's no mention of FCGI_STDIN for an FCGI_AUTHORIZER.  I
double-checked that mod_fcgid.c strips any CONTENT_LENGTH when calling
the authorizer, which the spec does call for.

I won't be shocked if it still fails for you; in that case I think we
need to try to understand exactly why the trailing FCGI_STDIN record
is needed.

(FWIW, my authorizer is Perl using the FCGI module.  The protocol
implementation on the app side could explain the difference in our
observations.)

--- modules/fcgid/fcgid_bridge.c.orig	2009-10-09 12:09:12.032405619 -0400
+++ modules/fcgid/fcgid_bridge.c	2009-10-09 15:12:25.838920760 -0400
@@ -470,6 +470,8 @@
         return HTTP_INTERNAL_SERVER_ERROR;
     }

+    if (role =3D=3D FCGI_RESPONDER) {
+
     /* Stdin header and body */
     /* XXX HACK: I have to read all the request into memory before sending=
 it
        to fastcgi application server, this prevents slow clients from
@@ -640,6 +642,8 @@
     }
     APR_BRIGADE_INSERT_TAIL(output_brigade, bucket_header);

+    } /* end handling request body for responders */
+
     /* The eos bucket now */
     bucket_eos =3D apr_bucket_eos_create(r->connection->bucket_alloc);
     APR_BRIGADE_INSERT_TAIL(output_brigade, bucket_eos);


--=20
Born in Roswell... married an alien...