Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 18790 invoked from network); 1 Oct 2009 11:27:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 1 Oct 2009 11:27:57 -0000 Received: (qmail 66629 invoked by uid 500); 1 Oct 2009 11:27:55 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 66557 invoked by uid 500); 1 Oct 2009 11:27:55 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 66546 invoked by uid 99); 1 Oct 2009 11:27:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2009 11:27:53 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates 209.85.220.218 as permitted sender) Received: from [209.85.220.218] (HELO mail-fx0-f218.google.com) (209.85.220.218) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Oct 2009 11:27:44 +0000 Received: by fxm18 with SMTP id 18so33951fxm.41 for ; Thu, 01 Oct 2009 04:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=zJ8p475AGkYsJIMtK2IZvALErIj6Mg+Tjw53cGXTgTA=; b=wH6g0yzNVwwalMOvUJcyU3Uw4A9otQyID6547Yy557yhTl56F/5N92uaOj9GHBJxy/ kxIkvdptRSHtx4yvwDSB+9PexvJc6o9+bE2e4hJqzLHTVwDNF9fgh8LExM2kjiak9hUg 6rd67BoGuJYT3LbZ3qEDhnA/rVZNyDyMrmH0U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=wzr7KvZh4y+9d8e0+QqfAfBh5vZMwdzWz3VDWtZFZiw/3gi320buESZGp1asfvUa40 MVtu9Ab5TT7AmAQe6okhTYyvQdI9ebbPdx/XYjkCWx0RrOaFhiVpbJHKngQTGvDsRkhB NNo0/Euiuo+id4giFDb6TRNNdG3S19mPvNUQQ= MIME-Version: 1.0 Received: by 10.86.230.30 with SMTP id c30mr1040374fgh.68.1254396383883; Thu, 01 Oct 2009 04:26:23 -0700 (PDT) In-Reply-To: <4AC40C5A.70707@apache.org> References: <20090930200037.E992123888E8@eris.apache.org> <4AC40C5A.70707@apache.org> Date: Thu, 1 Oct 2009 07:26:23 -0400 Message-ID: Subject: Re: svn commit: r820427 - in /httpd/httpd/trunk/modules: cluster/mod_heartmonitor.c core/mod_watchdog.c core/mod_watchdog.h From: Jeff Trawick To: dev@httpd.apache.org Content-Type: multipart/alternative; boundary=001485e29a4cde736f0474ddeaf6 X-Virus-Checked: Checked by ClamAV on apache.org --001485e29a4cde736f0474ddeaf6 Content-Type: text/plain; charset=ISO-8859-1 On Wed, Sep 30, 2009 at 9:56 PM, Guenter Knauf wrote: > Hi Jeff, > trawick@apache.org schrieb: > > Author: trawick > > Date: Wed Sep 30 20:00:37 2009 > > New Revision: 820427 > > > > URL: http://svn.apache.org/viewvc?rev=820427&view=rev > > Log: > > change the callable functions in the mod_watchdog API > > to optional hooks to avoid module ordering or other symbol > > resolution issues; affected: > > > > ap_watchdog_get_instance > > ap_watchdog_register_callback > > ap_watchdog_set_callback_interval > > > > Modified: > > httpd/httpd/trunk/modules/cluster/mod_heartmonitor.c > > httpd/httpd/trunk/modules/core/mod_watchdog.c > > httpd/httpd/trunk/modules/core/mod_watchdog.h > this breaks NetWare export list; and I did spent hours with Rainer last > time get the mod_watchdog exported symbols in; can you perhaps help a > bit with the awk stuff - I'm no expert with this; see: > http://svn.apache.org/viewvc?rev=820503&view=rev > where I started with it, but too late to get it right ATM ... > What is the symptom? The AP_WD_DECLARE stuff is still needed for the external hooks implemented by mod_watchdog, such as APR_DECLARE_EXTERNAL_HOOK(ap, AP_WD, int, watchdog_init, ( server_rec *s, const char *name, apr_pool_t *pool)) NetWare must already support APR_DECLARE_OPTIONAL_FN one way or another, long before this change. I'm unable to tell how mod_watchdog's use of that is different from existing modules, such as mod_ldap or mod_ssl or core. --001485e29a4cde736f0474ddeaf6 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Wed, Sep 30, 2009 at 9:56 PM, Guenter Knauf <= span dir=3D"ltr"><fuankg@apache.org= > wrote:
Hi Jeff,
trawick@apache.org schrieb:
> Author: trawick
> Date: Wed Sep 30 20:00:37 2009
> New Revision: 820427
>
> URL: http://svn.apache.org/viewvc?rev=3D820427&view=3D= rev
> Log:
> change the callable functions in the mod_watchdog API
> to optional hooks to avoid module ordering or other symbol
> resolution issues; affected:
>
> =A0 ap_watchdog_get_instance
> =A0 ap_watchdog_register_callback
> =A0 ap_watchdog_set_callback_interval
>
> Modified:
> =A0 =A0 httpd/httpd/trunk/modules/cluster/mod_heartmonitor.c
> =A0 =A0 httpd/httpd/trunk/modules/core/mod_watchdog.c
> =A0 =A0 httpd/httpd/trunk/modules/core/mod_watchdog.h
this breaks NetWare export list; and I did spent hours with Rainer la= st
time get the mod_watchdog exported symbols in; can you perhaps help a
bit with the awk stuff - I'm no expert with this; see:
http://svn.apache.org/viewvc?rev=3D820503&view=3Drev where I started with it, but too late to get it right ATM ...

What is the symptom?

The AP_WD_DECLARE stuff is still ne= eded for the external hooks implemented by mod_watchdog, such as

APR_DECLARE_EXTERNAL_HOOK(ap, AP_WD, int, watchdog_init, (
=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 server_rec = *s,
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0 const char *name,
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 apr_pool_t *pool))

NetWare must already support APR_DECLARE_OPTIONAL_FN one way o= r another, long before this change.=A0 I'm unable to tell how mod_watch= dog's use of that is different from existing modules, such as mod_ldap = or mod_ssl or core.

--001485e29a4cde736f0474ddeaf6--