Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 74285 invoked from network); 12 Oct 2009 21:16:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Oct 2009 21:16:35 -0000 Received: (qmail 98874 invoked by uid 500); 12 Oct 2009 21:16:34 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 98801 invoked by uid 500); 12 Oct 2009 21:16:33 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 98792 invoked by uid 99); 12 Oct 2009 21:16:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2009 21:16:33 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [208.83.223.140] (HELO ls6.firehawksystems.com) (208.83.223.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2009 21:16:23 +0000 Received: from mbp-wireless.brianfrance.com (adsl-99-162-53-239.dsl.ipltin.sbcglobal.net [99.162.53.239]) (authenticated bits=0) by ls6.firehawksystems.com (8.14.3/8.14.3) with ESMTP id n9CLFxvL081354 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Mon, 12 Oct 2009 14:16:00 -0700 (PDT) Content-Type: text/plain; charset=windows-1252; format=flowed; delsp=yes Mime-Version: 1.0 (Apple Message framework v1076) Subject: Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h From: "Brian J. France" In-Reply-To: <20091012203939.GB24807@redhat.com> Date: Mon, 12 Oct 2009 17:15:58 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <6526BE22-4CEB-434C-A3A8-C21799DB4CF3@brianfrance.com> References: <20091009214132.2DF4B23888C2@eris.apache.org> <4AD04029.3060500@apache.org> <20091012075828.GA7038@redhat.com> <62D3346B-F50A-4432-A733-76A928B2D0F6@brianfrance.com> <20091012203939.GB24807@redhat.com> To: dev@httpd.apache.org X-Mailer: Apple Mail (2.1076) X-Virus-Scanned: clamav-milter 0.95.1 at ls6.firehawksystems.com X-Virus-Status: Clean X-Virus-Checked: Checked by ClamAV on apache.org On Oct 12, 2009, at 4:39 PM, Joe Orton wrote: > On Mon, Oct 12, 2009 at 04:17:00PM -0400, Brian J. France wrote: >> On Oct 12, 2009, at 3:58 AM, Joe Orton wrote: >>> On Sat, Oct 10, 2009 at 10:04:57AM +0200, Ruediger Pluem wrote: >>>> This creates the following warning: >>>> >>>> repos.c:1827: warning: initialization from incompatible pointer =20 >>>> type >>> >>> Plus the dav_fs_get_request_rec prototype needs to be moved up. >>> >>> /local/asf/httpd-trunk/modules/dav/fs/repos.c:214: warning: no >>> previous >>> prototype for =91dav_fs_get_request_rec=92 >> >> I don't know why that warning is happening. dav_fs_get_request_rec is >> defined on line 214 and used in the struct on line 1827. > > Sorry, my mistake, it's not a positioning problem - the function needs > to be made static. Updated patch: Index: modules/dav/fs/repos.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- modules/dav/fs/repos.c (revision 824480) +++ modules/dav/fs/repos.c (working copy) @@ -211,7 +211,7 @@ ** ** PRIVATE REPOSITORY FUNCTIONS */ -request_rec *dav_fs_get_request_rec(const dav_resource *resource) +status request_rec *dav_fs_get_request_rec(const dav_resource =20 *resource) { return resource->info->r; } @@ -1823,9 +1823,9 @@ dav_fs_remove_resource, dav_fs_walk, dav_fs_getetag, + NULL, dav_fs_get_request_rec, - dav_fs_pathname, - NULL + dav_fs_pathname }; static dav_prop_insert dav_fs_insert_prop(const dav_resource =20 *resource,