Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of jorton@redhat.com designates
 209.132.183.28 as permitted sender)
Date: Wed, 21 Oct 2009 12:48:55 +0100
From: Joe Orton <jorton@redhat.com>
To: test-dev@perl.apache.org, dev@httpd.apache.org
Subject: Re: fixing an httpd test which is confused about which modules are
	loaded in the test conf
Message-ID: <20091021114855.GB5682@redhat.com>
Mail-Followup-To: test-dev@perl.apache.org, dev@httpd.apache.org
References: <cc67648e0910161232x6a9f35d2r7ef6d1515026468a@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cc67648e0910161232x6a9f35d2r7ef6d1515026468a@mail.gmail.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Organization: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor,
 Berkshire, SL4 1TE, United Kingdom.
  Registered in UK and Wales under Company Registration No. 03798903
  Directors: Michael Cunningham (USA), Brendan Lane (Ireland),
 Matt Parson (USA), Charlie Peters (USA)

On Fri, Oct 16, 2009 at 03:32:04PM -0400, Jeff Trawick wrote:
..
> --- Apache-Test/lib/Apache/TestConfigParse.pm	(revision 822728)
> +++ Apache-Test/lib/Apache/TestConfigParse.pm	(working copy)
> @@ -224,15 +224,15 @@
> 
>          $name = $modname_alias{$name} if $modname_alias{$name};
> 
> -        # remember all found modules
> -        $self->{modules}->{$name} = $file;
> -        debug "Found: $modname => $name";
> -
...
> 
> So is either of these a reasonable fix?  (It doesn't seem right that
> info.t has to worry about modules which were found in the
> configuration but not loaded, but I don't know what is expected of the
> configuration object.)

Either seems reasonable to me, though the use of the word "all" in the 
original comment above might imply the placement of that code is 
deliberate, so I'd probably go for the info.t patch.

Regards, Joe