Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 91025 invoked from network); 31 Oct 2009 12:34:35 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 31 Oct 2009 12:34:35 -0000 Received: (qmail 74015 invoked by uid 500); 31 Oct 2009 12:34:34 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 73916 invoked by uid 500); 31 Oct 2009 12:34:33 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 73907 invoked by uid 99); 31 Oct 2009 12:34:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Oct 2009 12:34:33 +0000 X-ASF-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of bojan@rexursive.com designates 150.101.121.179 as permitted sender) Received: from [150.101.121.179] (HELO beauty.rexursive.com) (150.101.121.179) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Oct 2009 12:34:31 +0000 Received: from [10.1.120.24] (shrek.rexursive.com [10.1.120.24]) by beauty.rexursive.com (Postfix) with ESMTP id 606F48CDF1 for ; Sat, 31 Oct 2009 23:34:10 +1100 (EST) Subject: Re: worker MPM: close_worker_sockets race? From: Bojan Smojver To: dev@httpd.apache.org In-Reply-To: <1256990441.2488.77.camel@shrek.rexursive.com> References: <1256173732.9540.23.camel@shrek.rexursive.com> <1256245093.9540.31.camel@shrek.rexursive.com> <1256253140.9540.33.camel@shrek.rexursive.com> <1256868439.2488.21.camel@shrek.rexursive.com> <1256875186.2488.39.camel@shrek.rexursive.com> <1256955260.2488.76.camel@shrek.rexursive.com> <1256990441.2488.77.camel@shrek.rexursive.com> Content-Type: text/plain Date: Sat, 31 Oct 2009 23:34:10 +1100 Message-Id: <1256992450.2488.78.camel@shrek.rexursive.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 (2.26.3-1.fc11) Content-Transfer-Encoding: 7bit On Sat, 2009-10-31 at 23:00 +1100, Bojan Smojver wrote: > + /* wait to resume */ > + while (suspend_workers) { > + apr_sleep(SCOREBOARD_MAINTENANCE_INTERVAL / 10); > + } Er, that should be: + /* suspend and then wait to resume */ + if (suspend_workers) { + worker_data[i].suspended = 1; + + while (suspend_workers) { + apr_sleep(SCOREBOARD_MAINTENANCE_INTERVAL / 10); + } + } -- Bojan