httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [VOTE] release httpd mod_fcgid-2.3.2?
Date Sat, 03 Oct 2009 23:59:23 GMT
On Sat, Oct 3, 2009 at 7:19 PM, Guenter Knauf <fuankg@apache.org> wrote:

> Bill,
> William A. Rowe, Jr. schrieb:
> > William A. Rowe, Jr. wrote:
> >>   [X] -1 for any release of 2.3.2 (regressed from 2.3.1?)
> >>   [ ] +1 to release as 2.3.2-beta
> >>   [ ] +1 to release as 2.3.2-GA
> >
> >
> C:\local0\asf\release\module-build\mod_fcgid\modules\fcgid\fcgid_pm_win.c(142)
> :
> >  error C2065: 'LOG_WARNING' : undeclared identifier
> > fcgid_proc_win.c
> a friend posted a patch to me about same but in fcgi_pm_unix.c ...
> I've not looked into it, but will shortly commit below if you dont
> object ...
>
> --- fcgid_pm_unix.c.orig        2009-09-18 06:14:45.000000000 +1000
> +++ fcgid_pm_unix.c     2009-09-30 12:52:22.609375000 +1000
> @@ -22,6 +22,7 @@
>  #include "apr_queue.h"
>  #include "apr_global_mutex.h"
>  #include "apr_support.h"
> +#include "http_config.h"
>

should be http_log.h AFAICT


> @@ -247,7 +248,7 @@
>         /* if running as root, switch to configured user */
>         if (ap_unixd_config.suexec_enabled) {
>             if (getuid() != 0) {
> -                ap_log_error(APLOG_MARK, LOG_EMERG, 0, main_server,
> +                ap_log_error(APLOG_MARK, APLOG_EMERG, 0, main_server,
>

go for it; it is a nice cleanup (but no operational change since the values
are by definition the same)

I broke the Windows logging with one of these non-AP LOG_foo, perhaps after
starting at these calls a while and not noticing ;)

Mime
View raw message