httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject Re: svn commit: r829619 - in /httpd/httpd/trunk: ./ modules/ssl/
Date Wed, 28 Oct 2009 15:40:17 GMT
Dr Stephen Henson schrieb:
> Guenter Knauf wrote:
>> Well, I guess its possible to do that - but isnt it possible to depend
>> on a OpenSSL version number here?
>>
> 
> How far do we have to go back here? OCSP support has been in OpenSSL since
> version 0.9.7 release 19 Feb 2003.
we have:

+#if OPENSSL_VERSION_NUMBER >= 0x00908080 && defined(HAVE_OCSP) \
+    && !defined(OPENSSL_NO_TLSEXT)
 #define HAVE_OCSP_STAPLING
 #endif

so we only support HAVE_OCSP_STAPLING with OpenSSL >= 0x00908080, and it
seems that we dont need to include openssl/ocsp.h if we dont set
HAVE_OCSP_STAPLING, so lets just move the above check up, and modify to:

#if (OPENSSL_VERSION_NUMBER >= 0x00908080) \
     && !defined(OPENSSL_NO_TLSEXT)
#define HAVE_OCSP_STAPLING
#include <openssl/ocsp.h>
#endif

and no further need for a HAVE_OCSP define on any platform ...

comments?

Gün.



Mime
View raw message