httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r823703 - in /httpd/httpd/trunk: CHANGES modules/dav/fs/repos.c modules/dav/main/mod_dav.h
Date Mon, 12 Oct 2009 20:32:39 GMT


On 10/12/2009 10:17 PM, Brian J. France wrote:
> 
> On Oct 12, 2009, at 3:58 AM, Joe Orton wrote:
> 
>> On Sat, Oct 10, 2009 at 10:04:57AM +0200, Ruediger Pluem wrote:
>>> On 10/09/2009 11:41 PM, minfrin@apache.org wrote:
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> ====================================================================
>>>> --- httpd/httpd/trunk/modules/dav/fs/repos.c (original)
>>>> +++ httpd/httpd/trunk/modules/dav/fs/repos.c Fri Oct  9 21:41:31 2009
>>>
>>>> @@ -1816,6 +1823,9 @@
>>>>     dav_fs_remove_resource,
>>>>     dav_fs_walk,
>>>>     dav_fs_getetag,
>>>> +    dav_fs_get_request_rec,
>>>> +    dav_fs_pathname,
>>>> +    NULL
>>>
>>> This creates the following warning:
>>>
>>> repos.c:1827: warning: initialization from incompatible pointer type
>>
>> Plus the dav_fs_get_request_rec prototype needs to be moved up.
>>
>> /local/asf/httpd-trunk/modules/dav/fs/repos.c:214: warning: no previous
>> prototype for ‘dav_fs_get_request_rec’
> 
> 
> I don't know why that warning is happening. dav_fs_get_request_rec is
> defined on line 214 and used in the struct on line 1827.

I guess because there is no prototype defined in repos.h like for dav_fs_pathname.
Furthermore I guess Joe didn't like that *ctx is no longer at the end of the struct.
I assume you did this to stay backportable, but IMHO this cannot be backported
anyway since adding fields to this struct and using them would cause
"old" providers that don't provide them when registering to possibly segfault.


Regards

Rüdiger

Mime
View raw message