httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r822094 - /httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c
Date Tue, 06 Oct 2009 20:31:34 GMT
Rainer Jung wrote:
> 
>>> Another thing is being able to split INSTDIR from APACHE2_HOME. The
>>> first is where the module should go to, the other one where httpd is. A
>>> simple tweak to the Makefile allows that. Then there's also an unconditional
>>>
>>> INSTDIR=\Apache22
>>>
>>> near the beginning of both Makefiles, which seems not right.
>> That's a default.  If INSTDIR is provided, that value is overridden.
> 
> Hmmm, it is applied a little down, but only if INSTDIR is not yet set.
> So setting the default is in the Makefile twice, once unconditionally,
> and then later down only if INSTDIR is not yet set. The unconditional
> one should go. Furthermore the test if it is already set should also be
> applied to APACHE2_HOME around the line, were APACHE2_HOME is set to
> INSTDIR.

Understand that if it's provided on the command line, the command line overrides.
It really is just a default.  But as you point out, bringing it in from the environment
requires that we protect it in an empty value test.

Right now we have it to initialize INSTDIR twice, and that's obviously wrong,
so I've adopted your suggestions, including reporting the APACHE2_HOME value.

I think all appropriate changes are now made, please review :)

Mime
View raw message