httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r821477 - in /httpd/httpd/trunk: CHANGES modules/http/byterange_filter.c modules/http/http_filters.c server/core_filters.c
Date Sun, 04 Oct 2009 09:12:07 GMT


On 10/04/2009 10:08 AM, sf@apache.org wrote:
> Author: sf
> Date: Sun Oct  4 08:08:50 2009
> New Revision: 821477
> 
> URL: http://svn.apache.org/viewvc?rev=821477&view=rev
> Log:
> Make sure to not destroy bucket brigades that have been created by earlier
> filters. Otherwise the pool cleanups would be removed causing potential memory
> leaks later on.
> 
> Modified:
>     httpd/httpd/trunk/CHANGES
>     httpd/httpd/trunk/modules/http/byterange_filter.c
>     httpd/httpd/trunk/modules/http/http_filters.c
>     httpd/httpd/trunk/server/core_filters.c
> 

> Modified: httpd/httpd/trunk/server/core_filters.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/server/core_filters.c?rev=821477&r1=821476&r2=821477&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/core_filters.c (original)
> +++ httpd/httpd/trunk/server/core_filters.c Sun Oct  4 08:08:50 2009

> @@ -392,19 +392,21 @@
>          }
>      }
>  
> +    if (new_bb != NULL) {
> +        bb = new_bb;
> +    }
> +

This could move in the block above, couldn't it?

Regards

RĂ¼diger



Mime
View raw message