httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: svn commit: r821202 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_cache.xml modules/cache/mod_cache.c modules/cache/mod_cache.h
Date Sat, 03 Oct 2009 12:21:31 GMT
Ruediger Pluem wrote:

> Hm, why don't we do the ap_meets_conditions test here like in the quick handler
> 
>     rv = ap_meets_conditions(r);
>     if (rv != OK) {
> 
>         /* Return cached status. */
>         return rv;
>     }

This code path is a normal handler, we don't need to. 
ap_meets_conditions() is already done by the core.

> Plus we have one new warning:
> 
> mod_cache.c: In function 'cache_handler':
> mod_cache.c:333: warning: unused variable 'auth'

Fixed in 821301.

Regards,
Graham
--

Mime
View raw message