httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: svn commit: r829185 - in /httpd/httpd/trunk: CHANGES modules/cache/mod_socache_shmcb.c
Date Sat, 24 Oct 2009 13:30:40 GMT
On Friday 23 October 2009, Ruediger Pluem wrote:
> > -    cp = strchr(path, '(');
> > -    if (cp) {
> > +    cp = strrchr(path, '(');
> > +    cp2 = path + strlen(path) - 1;
> > +    if (cp && (*cp2 == ')')) {
> >          *cp++ = '\0';
> > -
> > -        if (!(cp2 = strchr(cp, ')'))) {
> > -            return "Invalid argument: no closing parenthesis";
> > -        }
> 
> No error message any longer for missing parenthesis?
> I doubt that filenames like /somewhere/somefile(something are
>  intended.
> 

The question is if such filenames should be allowed. But I guess it's 
enought to allow them in case the cache size is given, too. Fixed in 
r829362

Mime
View raw message