httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: svn commit: r823337 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h include/http_core.h modules/loggers/mod_logio.c server/scoreboard.c
Date Thu, 08 Oct 2009 22:09:43 GMT
On Friday 09 October 2009, William A. Rowe, Jr. wrote:
> >>   * 20090925.0 (2.3.3-dev)  Added server_rec::context and added *server_rec
> >>   *                         param to ap_wait_or_timeout()
> >> + * 20090925.1 (2.3.3-dev)  Add optional function ap_logio_get_last_bytes()
to 
> >> + *                         mod_logio 
> >>   *
> >>   */
> >>  
> >>  #define MODULE_MAGIC_COOKIE 0x41503234UL /* "AP24" */
> >>  
> >>  #ifndef MODULE_MAGIC_NUMBER_MAJOR
> >> -#define MODULE_MAGIC_NUMBER_MAJOR 20090401
> >> +#define MODULE_MAGIC_NUMBER_MAJOR 20090925
> >>  #endif
> >> -#define MODULE_MAGIC_NUMBER_MINOR 2                     /* 0...n */
> >> +#define MODULE_MAGIC_NUMBER_MINOR 1                     /* 0...n */
> >
> > 
> > I updated MODULE_MAGIC_NUMBER_MAJOR to match the comments. I hope
> > this  is correct?
> 
> Nope - adding a function doesn't cost us MMN MAJOR (and never
>  delete MMN_MINOR, it just falls back to zero).

Sorry, that's not what I meant (and kmail sucks at quoting preformatted
mails).

The comments indicated MMN 20090925.0 but the code was at 20090401.2.
Therefore I assumed this was just forgotten and jumped to 20090925.1.

>
> MMN MAJOR jumps every time we encounter a change to an exported API
>  which users might be calling, which would result in erroneous
>  calls to the function from a module at an older build.  It
>  similarly changes when the fields of an existing public data
>  structure change (but not when they are extended).

Mime
View raw message