Return-Path: Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: (qmail 5803 invoked from network); 21 Sep 2009 11:06:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Sep 2009 11:06:37 -0000 Received: (qmail 23078 invoked by uid 500); 21 Sep 2009 11:06:36 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 22983 invoked by uid 500); 21 Sep 2009 11:06:36 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 22965 invoked by uid 99); 21 Sep 2009 11:06:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Sep 2009 11:06:35 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of trawick@gmail.com designates 72.14.220.154 as permitted sender) Received: from [72.14.220.154] (HELO fg-out-1718.google.com) (72.14.220.154) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Sep 2009 11:06:28 +0000 Received: by fg-out-1718.google.com with SMTP id 22so936950fge.12 for ; Mon, 21 Sep 2009 04:06:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=DbifoTqzXxDQRbMMDwfEIu0i3fOgZTaqXO0Rl0lZ768=; b=K/lX/4SNwrMwDkv4jGDde5BAWfMbaV6wiOcMapaiIpBkAc/VrLrNfx6GkpcEEXDWkN UQBhZQp/eNnuVtQJNFe90Rmtlzs6A9IwwRwfk6QfwxHvwGX39vmHrGWOh/aS8YTDoU00 SBGv0W/RS+xdbbcZp6s1TOtaV5XmOSYmZYUpw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=x3JrcvMu3PTN94iQYjsKi4/urQW673S3l2jawQNlMBs5c10Y6Xee7tsF0sXmrATh3g fefPgz5DGqdWl1rinKTr3475OUhyoZ996pej9FMiSc1O31epFCXaUrfqseBQwYEzlPdZ lnB+VPAXnAk7ilNZxgeqq3ZJKmAKoA59oykbU= MIME-Version: 1.0 Received: by 10.86.187.27 with SMTP id k27mr4531277fgf.11.1253531166765; Mon, 21 Sep 2009 04:06:06 -0700 (PDT) In-Reply-To: <4AB75B64.1040002@sharp.fm> References: <20090920175019.DE6C5238889D@eris.apache.org> <4AB6BBF7.3030203@apache.org> <4AB75B64.1040002@sharp.fm> Date: Mon, 21 Sep 2009 07:06:06 -0400 Message-ID: Subject: Re: svn commit: r817064 - in /httpd/httpd/branches/2.2.x: STATUS modules/aaa/mod_authnz_ldap.c From: Jeff Trawick To: dev@httpd.apache.org Content-Type: multipart/alternative; boundary=00163600d853e8f3470474147744 X-Virus-Checked: Checked by ClamAV on apache.org --00163600d853e8f3470474147744 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Sep 21, 2009 at 6:54 AM, Graham Leggett wrote: > Ruediger Pluem wrote: > > >> + /* pre-scan for ldap-* requirements so we can get out of the way > early */ > >> + for(x=0; x < reqs_arr->nelts; x++) { > > > > Why do we know that reqs_arr != NULL always? > > Wasn't that the FIXME comment that was included in the previous version > of this patch? > I hope this is the answer ;) http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?r1=815281&r2=815280&pathrev=815281 --00163600d853e8f3470474147744 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Mon, Sep 21, 2009 at 6:54 AM, Graham Leggett = <minfrin@sharp.fm<= /a>> wrote:
Ruediger Pluem wrote:

>> + =A0 =A0/* pre-scan for ldap-* requirements so we can get out of = the way early */
>> + =A0 =A0for(x=3D0; x < reqs_arr->nelts; x++) {
>
> Why do we know that reqs_arr !=3D NULL always?

Wasn't that the FIXME comment that was included in the previous v= ersion
of this patch?

--00163600d853e8f3470474147744--