Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of rainer.jung@kippdata.de
 designates 195.227.30.149 as permitted sender)
Message-ID: <4AA81DB7.5070408@kippdata.de>
Date: Wed, 09 Sep 2009 23:27:19 +0200
From: Rainer Jung <rainer.jung@kippdata.de>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de;
 rv:1.9.1.1) Gecko/20090715 Thunderbird/3.0b3
MIME-Version: 1.0
To: dev@httpd.apache.org
CC: testers@httpd.apache.org
Subject: Re: [VOTE] release httpd mod_fcgid-2.3.1?
References: <4AA6ED6A.2040207@rowe-clan.net>
In-Reply-To: <4AA6ED6A.2040207@rowe-clan.net>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit

On 09.09.2009 01:48, William A. Rowe, Jr. wrote:
> mod_fcgid freinds;
> 
> Please fetch up the newly minted mod_fcgid-2.3.1.tar.gz (or bz2)
> or the win32 suitable package mod_fcgid-2.3.1-crlf.zip from:
> 
>   http://httpd.apache.org/dev/dist/mod_fcgid/
> 
> review, take it for a spin, and cast your choice
> 
>   [ ] -1 for any release of 2.3.1 (regressed from 2.3.0?)
>   [X] +1 to release as 2.3.1-beta
>   [ ] +1 to release as 2.3.1-GA

> Note no configuration updates occur yet on make install.  Not sure what our
> 'example' aught to look like, yet.  Note no documentation was donated, so
> there is a reference to all of the directives taken from the cmd_rec array,
> but this needs attention from fans to fill in the text and correct a few
> more typos.

Tested against httpd 2.2.x on Solaris 8.

Signing good, hash files are in a format at least my md5sum and sha1sum
do not understand how to check.

configure runs fine.
Some minor warnings during make (all Solaris-specific):

fcgid_proctbl_unix.c:261: warning: format '%d' expects type 'int', but
argument 7 has type 'pid_t'
fcgid_proctbl_unix.c:268: warning: format '%d' expects type 'int', but
argument 7 has type 'pid_t'
fcgid_proctbl_unix.c:280: warning: format '%d' expects type 'int', but
argument 7 has type 'pid_t'
fcgid_pm_unix.c:239: warning: format '%d' expects type 'int', but
argument 7 has type 'pid_t'
fcgid_pm_unix.c:268: warning: format '%d' expects type 'int', but
argument 7 has type 'pid_t'
fcgid_proc_unix.c:229: warning: format '%d' expects type 'int', but
argument 5 has type 'pid_t'
fcgid_proc_unix.c:865: warning: format '%d' expects type 'int', but
argument 8 has type 'pid_t'

Tested with a simple echo server using ab and a few thousand requests.
Looks reliable.

I think it's still beta, because the docs are not enough to get one
started. Especially the description for FCGIWrapper is strange:

- I wasn't able to use it without the optional (?) second param:

In file fcgid_conf.c:

762 const char *set_wrapper_config(cmd_parms * cmd, void *dirconfig,
763                                const char *wrapperpath,
764                                const char *extension)
765 {
...
775     /* Sanity check */
776     if (wrapperpath == NULL || extension == NULL
-----------------------------------^^^^^^^^^^^^^^^^^
777         || *extension != '.' || *(extension + 1) == '\0'
778     ...
779         return "Invalid wrapper file extension";

although it is declared as

    AP_INIT_TAKE12("FCGIWrapper", set_wrapper_config, NULL,
                   RSRC_CONF | ACCESS_CONF | OR_FILEINFO,
                   "The CGI wrapper setting"),

- the needed "extension" is completely undocumented

- the path of wrapperpath is not resolved relative to the server root

Regards,

Rainer