Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <4AA80E84.90404@edelweb.fr>
Date: Wed, 09 Sep 2009 22:22:28 +0200
From: Peter Sylvester <peter.sylvester@edelweb.fr>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: [Fwd: backport and enhancement of patch 724717]
Content-Type: multipart/mixed;
 boundary="------------050202040204060609050407"

This is a multi-part message in MIME format.
--------------050202040204060609050407
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

I am not whether I have missed a response.
I think backporting this patch is not critical and
helps to remove differences between the
mod_ssl versions.

thanks in advance for consideration

/PS


--------------050202040204060609050407
Content-Type: message/rfc822;
 name="backport and enhancement of patch 724717.eml"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="backport and enhancement of patch 724717.eml"

Message-ID: <4A8E7ACC.80409@edelweb.fr>
Date: Fri, 21 Aug 2009 12:45:32 +0200
From: Peter Sylvester <Peter.Sylvester@edelweb.fr>
User-Agent: Thunderbird 1.5.0.9 (X11/20061206)
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: backport and enhancement of patch 724717
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

The patch for 724717 moves some logic from ssl_engine_kernel into
ssl__engine_vars and simplifies the code (and enhances it btw).
Can this code be backported to the 2.2.x version

The enhancement is to add the "_n" suffix for multiple occurences
of attributs which seems good. in addition it concentrates logic
at one place ...

... almost. Wouldn't it be better to move the for loop in the
following snippet of ssl_engine_kernel (and the ssl_hoolFixup_vars
table also inside the the routine above (changing maybe its name).

Thanks in advance for comments.
Peter Sylvester

  /* standard SSL environment variables */
   if (dc->nOptions & SSL_OPT_STDENVVARS) {
       modssl_var_extract_dns(env, sslconn->ssl, r->pool);

       for (i = 0; ssl_hook_Fixup_vars[i]; i++) {
           var = (char *)ssl_hook_Fixup_vars[i];
           val = ssl_var_lookup(r->pool, r->server, r->connection, r, var);
           if (!strIsEmpty(val)) {
               apr_table_setn(env, var, val);
           }
       }
   }


--------------050202040204060609050407--