Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of jorton@redhat.com designates
 209.132.183.28 as permitted sender)
Date: Mon, 14 Sep 2009 20:25:39 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: svn commit: r814652 -
	/httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c
Message-ID: <20090914192539.GA17030@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: <20090914141614.C59F5238886D@eris.apache.org>
 <4AAE93A8.7080605@apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4AAE93A8.7080605@apache.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Organization: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor,
 Berkshire, SL4 1TE, United Kingdom.
  Registered in UK and Wales under Company Registration No. 03798903
  Directors: Michael Cunningham (USA), Brendan Lane (Ireland),
 Matt Parson (USA), Charlie Peters (USA)

On Mon, Sep 14, 2009 at 09:04:08PM +0200, Ruediger Pluem wrote:
> On 09/14/2009 04:16 PM, jorton@apache.org wrote:
> > +    /* Reply syntax per RFC 2428: "229 blah blah (|||port|)" where '|'
> > +     * can be any character in ASCII from 33-126, obscurely.  Verify
> > +     * the syntax. */
> > +    p = ap_strchr(reply, '(');
> > +    if (p == NULL || !p[0] || !p[1] || p[1] != p[2] || p[1] != p[3]
> > +        || p[4] == p[1]) {
> 
> Hm. Isn't p[0] always == '(' if p != NULL?
> If yes !p[0] || could go away.

Yes, thanks - http://svn.apache.org/viewvc?view=rev&revision=814792