httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r818234 - in /httpd/mod_fcgid/trunk/modules/fcgid: fcgid_bridge.c fcgid_conf.c fcgid_conf.h
Date Wed, 23 Sep 2009 21:10:19 GMT
On Wed, Sep 23, 2009 at 5:04 PM, Ruediger Pluem <rpluem@apache.org> wrote:

>
>
> On 09/23/2009 10:10 PM, trawick@apache.org wrote:
> > Author: trawick
> > Date: Wed Sep 23 20:10:02 2009
> > New Revision: 818234
> >
> > URL: http://svn.apache.org/viewvc?rev=818234&view=rev
> > Log:
> > the request body size should be tracked and checked against
> > apr_off_t, not size_t and int
> >
> > Modified:
> >     httpd/mod_fcgid/trunk/modules/fcgid/fcgid_bridge.c
> >     httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c
> >     httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.h
> >
>
> > Modified: httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c
> > URL:
> http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c?rev=818234&r1=818233&r2=818234&view=diff
> >
> ==============================================================================
> > --- httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c (original)
> > +++ httpd/mod_fcgid/trunk/modules/fcgid/fcgid_conf.c Wed Sep 23 20:10:02
> 2009
> > @@ -354,13 +354,35 @@
> >      return NULL;
> >  }
> >
> > +static int strtoff(apr_off_t *val, const char *arg)
> > +{
> > +    char *errp;
> > +
> > +#if APR_MAJOR_VERSION < 1
> > +    *val = (apr_off_t)strtol(arg, &errp, 10);
> > +    if (*errp) {
> > +        return 1;
> > +    }
> > +#else
> > +    if (APR_SUCCESS != apr_strtoff(&conf->max_request_len, arg, &errp,
> 10) || *errp) {
>
> Why not val here instead of &conf->max_request_len?
> Copy and paste error ?
>

Yes, but worse yet I don't know what I was testing while experimenting with
the body size and the value of that directive (supposedly repeated for 2.0
and 2.2) :(

Thanks!

Mime
View raw message