httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r814743 - /httpd/httpd/branches/2.2.x/STATUS
Date Mon, 14 Sep 2009 18:05:44 GMT
On Mon, Sep 14, 2009 at 1:59 PM, Dan Poirier <poirier@pobox.com> wrote:

> On 09/14/2009 01:25 PM, trawick@apache.org wrote:
>
>> - * htcacheclean: 19 ways to fail, 1 error message. Fixed.
>> -   Trunk Patch: http://svn.apache.org/viewvc?view=rev&revision=814091
>> -   +1: minfrin, covener, poirier
>> +   -1: trawick (Memory use for dumping the database is now unbounded; it
>> +                doesn't even look difficult to avoid allocating/copying.)
>>
>>
> Can you elaborate?  I don't see how these changes create additional and
> unbounded memory usage.
>
>
Look at htdbm_list().

Without the patch, there is exactly one memory allocation (for
HUGE_STRING_LEN bytes) regardless of how many records are in the database.

After the patch, there are two memory allocations for every record in the
database.

Mime
View raw message