httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [VOTE] release httpd mod_fcgid-2.3.1?
Date Thu, 10 Sep 2009 15:15:27 GMT
On Wed, Sep 9, 2009 at 4:51 PM, Jeff Trawick <trawick@gmail.com> wrote:

> On Tue, Sep 8, 2009 at 7:48 PM, William A. Rowe, Jr. <wrowe@rowe-clan.net>wrote:
>
>> mod_fcgid freinds;
>>
>> Please fetch up the newly minted mod_fcgid-2.3.1.tar.gz (or bz2)
>> or the win32 suitable package mod_fcgid-2.3.1-crlf.zip from:
>>
>>  http://httpd.apache.org/dev/dist/mod_fcgid/
>>
>> review, take it for a spin, and cast your choice
>>
>>  [ ] -1 for any release of 2.3.1 (regressed from 2.3.0?)
>>  [ ] +1 to release as 2.3.1-beta
>>  [ ] +1 to release as 2.3.1-GA
>>
>
> I've poked at it a little on a couple of platforms (so far so good); I
> anticipate being able to vote by tomorrow.
>
>
I've been experimenting with AAA, and am currently getting massive bogosity
-- an access checker script is called for authorization -- on subsequent
requests.

Some messages don't help either ;)

@@ -387,7 +397,7 @@
     {
         /* Pass */
         ap_log_rerror(APLOG_MARK, APLOG_DEBUG | APLOG_NOERRNO, 0, r,
-                      "mod_fcgid: access granted");
+                      "mod_fcgid: access granted (authorization)");

         /* Modify headers: An Authorizer application's 200 response may
include headers
            whose names are prefixed with Variable-.  */
@@ -399,15 +409,15 @@
         /* Print error info first */
         if (res != OK)
             ap_log_rerror(APLOG_MARK, APLOG_WARNING | APLOG_NOERRNO, 0, r,
-                          "mod_fcgid: user %s access check failed, respond
%d, URI %s",
+                          "mod_fcgid: user %s authorization failed, respond
%d, URI %s",
                           r->user, res, r->uri);
         else if (r->status != 200)
             ap_log_rerror(APLOG_MARK, APLOG_WARNING | APLOG_NOERRNO, 0, r,
-                          "mod_fcgid: user %s access check failed, status
%d, URI %s",
+                          "mod_fcgid: user %s authorization failed, status
%d, URI %s",
                           r->user, r->status, r->uri);
         else
             ap_log_rerror(APLOG_MARK, APLOG_WARNING | APLOG_NOERRNO, 0, r,
-                          "mod_fcgid: user %s access check failed,
redirected is not allowed",
+                          "mod_fcgid: user %s authorization failed,
redirected is not allowed",
                           r->user);

         /* Handle error */

I'll commit the message change for sure, and hope to straighten out the more
serious issue (which may or may not be a regression).

Mime
View raw message