httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Memory usage, core output filter, and apr_brigade_destroy
Date Sun, 13 Sep 2009 11:11:04 GMT
Hi,

http://httpd.apache.org/docs/trunk/developer/output-filters.html 
recommends to reuse bucket brigades and to not use apr_brigade_destroy. 
However, both in 2.2 and in trunk, the core output filter sometimes calls 
apr_brigade_destroy on brigades that it has received down the chain from 
earlier output filters. Is this not bound to cause problems since the 
brigade's pool cleanup is then removed but the brigade is still reused 
later on?

Also, the core output filter often creates new brigades instead of reusing 
an existing brigade. This should also be changed to reduce memory usage, 
shouldn't it?

For trunk, the attached patch at least keeps the temporary brigade for 
flush buckets around. Do the versioning rules allow to add elements to 
core_output_filter_ctx for 2.2.x, too? It's defined in httpd.h.

Cheers,
Stefan
Mime
View raw message