httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Roy T. Fielding" <field...@gbiv.com>
Subject Re: [PATCH] roll.sh output equal checksum files independent of OS
Date Thu, 24 Sep 2009 22:17:06 GMT
On Sep 24, 2009, at 2:11 PM, Guenter Knauf wrote:

> Hi,
> here's based on input from Rainer and RĂ¼diger my last trial unless  
> I get
> further positive comments instead of disappointing ones ...
> highlighted:
> http://people.apache.org/~fuankg/testchecksum/testchecksums.sh.html
> plaintext:
> http://people.apache.org/~fuankg/testchecksum/testchecksums.sh.txt
> with .sh extension for download:
> http://people.apache.org/~fuankg/testchecksum/testchecksums.sh
>
> tested on:
> - Linux (OpenSuSE) with openssl, gpg, md5sum / sha1sum
> - FreeBSD (p.a.o) with openssl and md5 / sha1
>
> it will most likely also work correctly on MacOSX.

I get

% sh testchecksums.sh fred

Generating MD5/SHA1 checksum files ...

openssl: creating md5 checksum file for fred.tar.gz ...
openssl: creating sha1 checksum file for fred.tar.gz ...
openssl: creating md5 checksum file for fred.tar.bz2 ...
openssl: creating sha1 checksum file for fred.tar.bz2 ...
openssl: creating md5 checksum file for fred-deps.tar.gz ...
openssl: creating sha1 checksum file for fred-deps.tar.gz ...
openssl: creating md5 checksum file for fred-deps.tar.bz2 ...
openssl: creating sha1 checksum file for fred-deps.tar.bz2 ...
testchecksums.sh: line 80: test: too many arguments
testchecksums.sh: line 92: test: too many arguments

My guess is that

   if test -x ${md5sum} -a ${sha1sum}; then

won't work when md5sum or sha1sum is empty.  Likewise for line 92.
Though we probably don't even need those parts for roll.sh.

....Roy


Mime
View raw message