httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject [PATCH-REVIEW] shm.c
Date Tue, 29 Sep 2009 02:10:52 GMT
Hi Jeff,
Jeff Trawick schrieb:
> IMO we should just let it be; users/developers can set CFLAGS to
> suppress it if desired.  
personally I dislike to globaly suppress warnings since at some point we
might hide also real problems - and if we can fix it then I think we
should do ...; as I showed with my sample gcc warns too if the related
warning is enabled - its just that we usually compile without ...

> (Perhaps non-suppressing Sun Studio users among the developers will
> notice when a new one crops up and evaluate whether or not it is a real
> problem; perhaps other compilers will warn in scenarios where it is more
> likely?)
can you perhaps review and verify if this patch fixes the Sun Studio
warnings in shm.c?
http://people.apache.org/~fuankg/diffs/shm.c.diff
whole file apr/shmem/unix/shm.c:
http://people.apache.org/~fuankg/diffs/shm.c
Maybe I did something wrong, but at least it compiled for me on Linux,
and all tests passed ...

Gün.




Mime
View raw message