httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r808907 - in /httpd/httpd/branches/2.2.x: CHANGES docs/manual/mod/mod_cache.xml modules/cache/cache_storage.c modules/cache/mod_cache.c modules/cache/mod_cache.h
Date Sun, 27 Sep 2009 00:10:24 GMT


On 09/26/2009 11:30 PM, Jeff Trawick wrote:
> On Fri, Aug 28, 2009 at 10:52 AM, <jim@apache.org> wrote:
> 
>> Author: jim
>> Date: Fri Aug 28 14:52:38 2009
>> New Revision: 808907
>>
>> URL: http://svn.apache.org/viewvc?rev=808907&view=rev
>> Log:
>> Ummm... update the code :)
>>
> 
> Helpful log there, Jim ;)
> 
> 
>> Modified:
>>    httpd/httpd/branches/2.2.x/CHANGES
>>    httpd/httpd/branches/2.2.x/docs/manual/mod/mod_cache.xml
>>    httpd/httpd/branches/2.2.x/modules/cache/cache_storage.c
>>    httpd/httpd/branches/2.2.x/modules/cache/mod_cache.c
>>    httpd/httpd/branches/2.2.x/modules/cache/mod_cache.h
>>
>> Modified: httpd/httpd/branches/2.2.x/modules/cache/mod_cache.h
>> URL:
>> http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/modules/cache/mod_cache.h?rev=808907&r1=808906&r2=808907&view=diff
>>
>> ==============================================================================
>> --- httpd/httpd/branches/2.2.x/modules/cache/mod_cache.h (original)
>> +++ httpd/httpd/branches/2.2.x/modules/cache/mod_cache.h Fri Aug 28
>> 14:52:38 2009
>> @@ -153,6 +153,12 @@
>>     /** ignore query-string when caching */
>>     int ignorequerystring;
>>     int ignorequerystring_set;
>> +    /** store the identifiers that should not be used for key calculation
>> */
>> +    apr_array_header_t *ignore_session_id;
>> +    /* flag if CacheIgnoreURLSessionIdentifiers has been set */
>> +    #define CACHE_IGNORE_SESSION_ID_SET   1
>> +    #define CACHE_IGNORE_SESSION_ID_UNSET 0
>> +    int ignore_session_id_set;
>>  } cache_server_conf;
>>
> 
> I see a past mmn bump when cache_server_conf was modified (r370101).
> 
> Should it have been bumped for this?

mod_cache.h is currently only a public header in trunk (copied to include directory
by make install). It is not in 2.2.x. So I guess it is formally correct not to bump
(is it true that we do not need to bump for headers that don't end up in include ???)
Nevertheless during the last extension of cache_server_conf I "missed" the bump
as well: http://svn.apache.org/viewvc?view=rev&revision=539111
So I guess it is not big issue if we missed, but I should take more care in
the future if there really should have been one.

Regards

RĂ¼diger


Mime
View raw message