httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject Re: [PATCH] roll.sh output equal checksum files independent of OS
Date Thu, 24 Sep 2009 22:42:34 GMT
Hi,
Roy T. Fielding schrieb:
> I get
> 
> % sh testchecksums.sh fred
> 
> Generating MD5/SHA1 checksum files ...
> 
> openssl: creating md5 checksum file for fred.tar.gz ...
> openssl: creating sha1 checksum file for fred.tar.gz ...
> openssl: creating md5 checksum file for fred.tar.bz2 ...
> openssl: creating sha1 checksum file for fred.tar.bz2 ...
> openssl: creating md5 checksum file for fred-deps.tar.gz ...
> openssl: creating sha1 checksum file for fred-deps.tar.gz ...
> openssl: creating md5 checksum file for fred-deps.tar.bz2 ...
> openssl: creating sha1 checksum file for fred-deps.tar.bz2 ...
> testchecksums.sh: line 80: test: too many arguments
> testchecksums.sh: line 92: test: too many arguments
> 
> My guess is that
> 
>   if test -x ${md5sum} -a ${sha1sum}; then
> 
> won't work when md5sum or sha1sum is empty.  Likewise for line 92.
good catch! My bad - forgot to quote, and forgot to add another -x ...
just fixed, please test again with updated script.

> Though we probably don't even need those parts for roll.sh.
I did it mainly for the testscript so everyone can verify that the
format is compatible ...

thanks, Gün.


Mime
View raw message