httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [VOTE] release httpd mod_ftp-0.9.5 beta?
Date Wed, 23 Sep 2009 02:56:14 GMT
Guenter Knauf wrote:
> 
>> FEAT -> UTF8 tells the client that utf8 is preferred.  On unix systems
>> today, that is largely true.  On Windows, it's absolutely true from the
>> httpd perspective.  And I'm conceding it might be wrong for OS2 or Netware
>> and need your feedback.  FEAT -> UTF8 does not say UTF8 is the only format
>> to expect, only that it's the format that should be presumed.
> not 100% sure, but ATM would say NW does not support UTF8 with the
> filenames without conversion ... (we had problems in the past with
> filenames on httpd autoindexed pages, and need mod_chatset_lite to
> workaround this)

Then I'll roll tomorrow afternoon along with mod_fcgid.  We have two ways to
handle this; FTPOptions NoUTF8Feature, or something like;

--- mod_ftp.c   (revision 816386)
+++ mod_ftp.c   (working copy)
@@ -86,12 +86,14 @@

     ap_add_version_component(p, FTP_SERVER_STRING);

+#if !defined(NETWARE) && !defined(OS2)
     /*
      * Unless disabled, advertise that UTF8 filenames are preferred/permitted
      * RFC2640 never -requires- UTF8 names
      */
     if (!(basefsc->options & FTP_OPT_NO_UTF8_FEAT))
         ftp_feat_advert("UTF8");
+#endif

     /* Finalize ftp_cmd_help and ftp_cmd_feat messages */
     ftp_cmd_finalize(p, ptemp);


thoughts?

Mime
View raw message