httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject Re: [VOTE] release httpd mod_ftp-0.9.5 beta?
Date Tue, 22 Sep 2009 23:42:13 GMT
Bill,
William A. Rowe, Jr. schrieb:
> Guenter Knauf wrote:
>> ftp_commands.c: In function ‘common_list’:
>>
>> ftp_commands.c:694: warning: suggest parentheses around && within ||
> 
> As we worked out, the distinction made no effective difference, but...
> 
>> ftp_protocol.c: In function ‘ftp_read_line’:
>> ftp_protocol.c:244: warning: comparison is always false due to limited
>> range of data type
>> ftp_protocol.c:246: warning: comparison is always false due to limited
>> range of data type
>> ftp_protocol.c:246: warning: comparison is always true due to limited
>> range of data type
>> ftp_protocol.c:255: warning: comparison is always false due to limited
>> range of data type
>> ftp_protocol.c:258: warning: comparison is always false due to limited
>> range of data type
>> ftp_protocol.c:258: warning: comparison is always true due to limited
>> range of data type
>>
>> we should fix these first, and re-roll ...
> 
> that sounds right; this code was faulty on platforms where '\xff' != 0xff.
found another issue while testing with FileZilla:
Befehl:	FEAT
Antwort:	211-Extensions supported
Antwort:	 TVFS
Antwort:	 UTF8
Antwort:	 REST STREAM
Antwort:	 MDTM
Antwort:	 EPRT
Antwort:	 SIZE
Antwort:	 PBSZ
Antwort:	 PROT
Antwort:	 AUTH TLS
Antwort:	 EPSV
Antwort:	211 End
Befehl:	OPTS UTF8 ON
Antwort:	504 Error (no message)

so clearly mod_ftp now claims to support UTF8, but when FZ tries to set
it then it returns an error ....

Gün.




Mime
View raw message