httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: [VOTE] release httpd mod_ftp-0.9.5 beta?
Date Wed, 16 Sep 2009 23:28:09 GMT
Guenter Knauf wrote:
> ftp_commands.c: In function ‘common_list’:
> 
> ftp_commands.c:694: warning: suggest parentheses around && within ||

As we worked out, the distinction made no effective difference, but...

> ftp_protocol.c: In function ‘ftp_read_line’:
> ftp_protocol.c:244: warning: comparison is always false due to limited
> range of data type
> ftp_protocol.c:246: warning: comparison is always false due to limited
> range of data type
> ftp_protocol.c:246: warning: comparison is always true due to limited
> range of data type
> ftp_protocol.c:255: warning: comparison is always false due to limited
> range of data type
> ftp_protocol.c:258: warning: comparison is always false due to limited
> range of data type
> ftp_protocol.c:258: warning: comparison is always true due to limited
> range of data type
> 
> we should fix these first, and re-roll ...

that sounds right; this code was faulty on platforms where '\xff' != 0xff.

Mime
View raw message