httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r815527 - /httpd/mod_ftp/trunk/modules/ftp/ftp_commands.c
Date Tue, 15 Sep 2009 22:48:45 GMT
fuankg@apache.org wrote:
>      /* Special FTPOption that maps NLST directly to LIST */
> -    if (!is_list && (fsc->options & FTP_OPT_NLSTISLIST) || dashl) {
> +    if ((!is_list && (fsc->options & FTP_OPT_NLSTISLIST)) || dashl) {
>          is_list = 1;
>      }

Wouldn't this be

  if (!is_list && ((fsc->options & FTP_OPT_NLSTISLIST) || dashl)) {

as there is no point otherwise?  Actually we could drop the !is_list test,
considering that forced-override isn't harmful.

Mime
View raw message